4aiman/baldav
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix dedup FK: delete product_units refs before products, remove PRAGMA hack

Browse source 
FOREIGN KEY constraint failed because product_units table has FK to
products(id) and wasn't cleaned before DELETE. Now: delete orphaned
product_units rows first, then delete dupe products. No PRAGMA needed.

Verified on desktop: 16675 → 8330 with FK enforcement ON.
This commit is contained in:
4aiman 2026-06-01 22:43:02 +03:00
commit c72a22a965
1 changed files with 7 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src-tauri/src/lib.rs
View file

@ -140,8 +140,6 @@ fn import_seed_products(app: tauri::AppHandle) -> Result<String, String> {
}
// Dedup ALWAYS runs (even if seed version matches) — fixes legacy duplicates.
// Disable FK checks during dedup (refs reassigned before delete, but rusqlite enforces FK by default)
let _ = main_db.execute("PRAGMA foreign_keys = OFF", []);
let _ = main_db.execute(
"CREATE INDEX IF NOT EXISTS idx_products_name_lower ON products(name_lower)", []);
@ -168,6 +166,13 @@ fn import_seed_products(app: tauri::AppHandle) -> Result<String, String> {
GROUP BY name_lower, source, COALESCE(store_id,'')
)", []).map_err(|e| format!("dedup recipe_ingredients: {}", e))?;
// Reassign product_units (also has FK to products)
main_db.execute(
"DELETE FROM product_units WHERE product_id NOT IN (
SELECT MIN(id) FROM products WHERE name_lower IS NOT NULL
GROUP BY name_lower, source, COALESCE(store_id,'')
)", []).map_err(|e| format!("dedup product_units: {}", e))?;
main_db.execute(
"DELETE FROM products WHERE name_lower IS NOT NULL
AND id NOT IN (
@ -180,8 +185,6 @@ fn import_seed_products(app: tauri::AppHandle) -> Result<String, String> {
ON products(name_lower, source, COALESCE(store_id, ''))
WHERE name_lower IS NOT NULL", []);
let _ = main_db.execute("PRAGMA foreign_keys = ON", []);
// Check seed version — skip import if already up to date
let current_version: i64 = main_db.query_row(
"SELECT COALESCE((SELECT value FROM profile WHERE key='seed_version'), '0')",