4aiman/obs-studio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UI: Don't double-delete children of deleted widgets

Browse source 
These widgets are all children of updateSettingsGroupBox, meaning they
get deleted when updateSettingsGroupBox gets deleted. This means that
the first two calls are unnecessary and the third one segfaults as
updateChannelLabel is gone already.
Just delete the parent widget instead.
This commit is contained in:
gxalpha 2023-02-19 13:57:14 +01:00 • committed by Rodney
commit 19a0afe526
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
UI/window-basic-settings.cpp
View file

@ -577,14 +577,11 @@ OBSBasicSettings::OBSBasicSettings(QWidget *parent)
ui->advOutFFABitrate->setSuffix(" Kbps");
#if !defined(_WIN32) && !defined(__APPLE__)
delete ui->enableAutoUpdates;
ui->enableAutoUpdates = nullptr;
delete ui->updateChannelBox;
ui->updateChannelBox = nullptr;
delete ui->updateSettingsGroupBox;
ui->updateSettingsGroupBox = nullptr;
delete ui->updateChannelLabel;
ui->updateChannelLabel = nullptr;
ui->updateChannelBox = nullptr;
ui->enableAutoUpdates = nullptr;
#else
// Hide update section if disabled
if (App()->IsUpdaterDisabled())