UI: Fix possible use-after-free of obs_source_t

Also removes an implicit pair of successive obs_source_getref and
obs_source_release calls from OBSSource.
This commit is contained in:
Norihiro Kamae 2023-03-18 12:56:50 +09:00 • committed by Jim
commit 23a0b7cacd
4 changed files with 6 additions and 9 deletions

View file

@ -114,8 +114,8 @@ struct OBSStudioAPI : obs_frontend_callbacks {
struct obs_frontend_source_list *sources) override
{
for (int i = 0; i < main->ui->transitions->count(); i++) {
obs_source_t *tr = main->ui->transitions->itemData(i)
.value<OBSSource>();
OBSSource tr = main->ui->transitions->itemData(i)
.value<OBSSource>();
if (!tr)
continue;