4aiman/obs-studio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UI: Fix possible use-after-free of obs_source_t

Browse source 
Also removes an implicit pair of successive obs_source_getref and
obs_source_release calls from OBSSource.
This commit is contained in:
Norihiro Kamae 2023-03-18 12:56:50 +09:00 • committed by Jim
commit 23a0b7cacd
4 changed files with 6 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
UI/window-basic-main.cpp
View file

@ -733,7 +733,7 @@ obs_data_array_t *OBSBasic::SaveProjectors()
switch (type) {
case ProjectorType::Scene:
case ProjectorType::Source: {
obs_source_t *source = projector->GetSource();
OBSSource source = projector->GetSource();
const char *name = obs_source_get_name(source);
obs_data_set_string(data, "name", name);
break;
@ -5393,8 +5393,8 @@ void OBSBasic::on_actionAddScene_triggered()
auto undo_fn = [](const std::string &data) {
obs_source_t *t = obs_get_source_by_name(data.c_str());
if (t) {
obs_source_release(t);
obs_source_remove(t);
obs_source_release(t);
}
};