4aiman/obs-studio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UI: Fix themeDir buffer being resized incorrectly

Browse source 
c677bac875 changed the order here, but
this also resulted in the string having whatever size was necessary for
the install data path, rather than being large enough to fit a userdata
path. To fix this, move the resize operaetion *after* the buit-in
themes are searched, and also bump it to 1024 just to be sure.

This resulted in a crash due to a bug in os_get_path_internal() which
will need to be fixed separately.
This commit is contained in:
derrod 2024-06-12 22:03:23 +02:00 • committed by Ryan Foster
commit 4a46d2d722
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
UI/obs-app-theming.cpp
View file

@ -417,7 +417,6 @@ static vector<OBSThemeVariable> ParseThemeVariables(const char *themeData)
void OBSApp::FindThemes()
{
string themeDir;
themeDir.resize(512);
QStringList filters;
filters << "*.obt" // OBS Base Theme
@ -435,6 +434,7 @@ void OBSApp::FindThemes()
delete theme;
}
themeDir.resize(1024);
if (GetConfigPath(themeDir.data(), themeDir.capacity(),
"obs-studio/themes/") > 0) {
QDirIterator it(QT_UTF8(themeDir.c_str()), filters,