4aiman/obs-studio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UI: Don't re-apply theme when saving Settings

Browse source 
When the user changes theme, it is applied immediately. If the user
clicks Cancel, the previous theme is restored. This additional SetTheme
call was unnecessarily causing the existing theme to be re-applied,
resulting in a momentary hang without clear cause.
This commit is contained in:
Matt Gajownik 2022-07-04 23:00:15 +10:00
commit 570c904977
1 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
UI/window-basic-settings.cpp
View file

@ -3094,13 +3094,10 @@ void OBSBasicSettings::SaveGeneralSettings()
if (themeData == defaultTheme)
themeData = DEFAULT_THEME;
if (WidgetChanged(ui->theme)) {
if (WidgetChanged(ui->theme))
config_set_string(GetGlobalConfig(), "General", "CurrentTheme2",
QT_TO_UTF8(themeData));
App()->SetTheme(themeData.toUtf8().constData());
}
#if defined(_WIN32) || defined(__APPLE__)
if (WidgetChanged(ui->enableAutoUpdates))
config_set_bool(GetGlobalConfig(), "General",