4aiman/obs-studio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

UI: Add warning if starting the output fails

Browse source 
This is mainly to give visual feedback to those affected by NVENC not
working with older driver versions. Currenlty obs fails silently which
could go unnoticed for users who are using hotkeys as well as confuse
users who are not trained to read their logs when issues occur.

Closes jp9000/obs-studio#788
This commit is contained in:
derrod 2017-02-04 05:29:09 +01:00 • committed by jp9000
commit 6bc1ecc794
3 changed files with 29 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

23
UI/window-basic-main-outputs.cpp
View file

@ -837,8 +837,13 @@ bool SimpleOutput::StartRecording()
UpdateRecording();
if (!ConfigureRecording(false))
return false;
if (!obs_output_start(fileOutput))
if (!obs_output_start(fileOutput)) {
QMessageBox::critical(main,
QTStr("Output.StartRecordingFailed"),
QTStr("Output.StartFailedGeneric"));
return false;
}
return true;
}
@ -847,8 +852,13 @@ bool SimpleOutput::StartReplayBuffer()
UpdateRecording();
if (!ConfigureRecording(true))
return false;
if (!obs_output_start(replayBuffer))
if (!obs_output_start(replayBuffer)) {
QMessageBox::critical(main,
QTStr("Output.StartReplayFailed"),
QTStr("Output.StartFailedGeneric"));
return false;
}
return true;
}
@ -1399,11 +1409,14 @@ bool AdvancedOutput::StartRecording()
obs_data_release(settings);
}
if (obs_output_start(fileOutput)) {
return true;
if (!obs_output_start(fileOutput)) {
QMessageBox::critical(main,
QTStr("Output.StartRecordingFailed"),
QTStr("Output.StartFailedGeneric"));
return false;
}
return false;
return true;
}
void AdvancedOutput::StopStreaming(bool force)