4aiman/obs-studio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

frontend: Use static_cast when casting from void pointers

Browse source 
Using static_cast is preferred here, as it is safer to use than
reinterpret_cast.
This commit is contained in:
cg2121 2025-01-28 04:28:33 -06:00 • committed by Ryan Foster
commit d7cce79d7e
22 changed files with 73 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

14
frontend/components/SourceTreeItem.cpp
View file

@ -172,7 +172,7 @@ void SourceTreeItem::ReconnectSignals()
/* --------------------------------------------------------- */
auto removeItem = [](void *data, calldata_t *cd) {
SourceTreeItem *this_ = reinterpret_cast<SourceTreeItem *>(data);
SourceTreeItem *this_ = static_cast<SourceTreeItem *>(data);
obs_sceneitem_t *curItem = (obs_sceneitem_t *)calldata_ptr(cd, "item");
obs_scene_t *curScene = (obs_scene_t *)calldata_ptr(cd, "scene");
@ -186,7 +186,7 @@ void SourceTreeItem::ReconnectSignals()
};
auto itemVisible = [](void *data, calldata_t *cd) {
SourceTreeItem *this_ = reinterpret_cast<SourceTreeItem *>(data);
SourceTreeItem *this_ = static_cast<SourceTreeItem *>(data);
obs_sceneitem_t *curItem = (obs_sceneitem_t *)calldata_ptr(cd, "item");
bool visible = calldata_bool(cd, "visible");
@ -195,7 +195,7 @@ void SourceTreeItem::ReconnectSignals()
};
auto itemLocked = [](void *data, calldata_t *cd) {
SourceTreeItem *this_ = reinterpret_cast<SourceTreeItem *>(data);
SourceTreeItem *this_ = static_cast<SourceTreeItem *>(data);
obs_sceneitem_t *curItem = (obs_sceneitem_t *)calldata_ptr(cd, "item");
bool locked = calldata_bool(cd, "locked");
@ -204,7 +204,7 @@ void SourceTreeItem::ReconnectSignals()
};
auto itemSelect = [](void *data, calldata_t *cd) {
SourceTreeItem *this_ = reinterpret_cast<SourceTreeItem *>(data);
SourceTreeItem *this_ = static_cast<SourceTreeItem *>(data);
obs_sceneitem_t *curItem = (obs_sceneitem_t *)calldata_ptr(cd, "item");
if (curItem == this_->sceneitem)
@ -212,7 +212,7 @@ void SourceTreeItem::ReconnectSignals()
};
auto itemDeselect = [](void *data, calldata_t *cd) {
SourceTreeItem *this_ = reinterpret_cast<SourceTreeItem *>(data);
SourceTreeItem *this_ = static_cast<SourceTreeItem *>(data);
obs_sceneitem_t *curItem = (obs_sceneitem_t *)calldata_ptr(cd, "item");
if (curItem == this_->sceneitem)
@ -220,7 +220,7 @@ void SourceTreeItem::ReconnectSignals()
};
auto reorderGroup = [](void *data, calldata_t *) {
SourceTreeItem *this_ = reinterpret_cast<SourceTreeItem *>(data);
SourceTreeItem *this_ = static_cast<SourceTreeItem *>(data);
QMetaObject::invokeMethod(this_->tree, "ReorderItems");
};
@ -245,7 +245,7 @@ void SourceTreeItem::ReconnectSignals()
/* --------------------------------------------------------- */
auto removeSource = [](void *data, calldata_t *) {
SourceTreeItem *this_ = reinterpret_cast<SourceTreeItem *>(data);
SourceTreeItem *this_ = static_cast<SourceTreeItem *>(data);
this_->DisconnectSignals();
this_->sceneitem = nullptr;
QMetaObject::invokeMethod(this_->tree, "RefreshItems");