The upload step in the job uses the output of two prior steps as its
condition. One of the jobs itself is a conditional job, so if the
primary condition is not met, the secondary output is not set and the
fromJSON call will fail.
Using a string comparison allows the check to still work as expected
(as the output will be an empty string otherwise)
When a prior scheduled nightly run is detected with the identical
commit hash, then the entire language file check should be skipped.
This adds the missing condition to skip the check for changed files
removing the unnecessary warning contained in the workflow results.
This is what Flathub uses now. It's an implementation detail that will
eventually be hidden away in a Flathub-specific publish action. But for
now, we still publish directly, and we have to adapt.
When merging the PR for the previous commits, I forgot the note that
stated that it required a merge commit to preserve the pinned commit
hash for the workflow. Thus, when I merged with "Rebase and merge", the
commit hash changed, and the workflow broke.
Update the commit hash to the correct version and fix my mistake.
Implement the new merge sub-action from upload-artifact as a separate
job that requires the Sparkle appcast creation job so that we still get
a single combined artifact for the Sparkle appcast. This lets us update
upload-artifact from v3 to v4.
GitHub Actions has deprecated Actions based on node16. The v4 actions
are based on node20.
See:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Validate the Flatpak manifest before building it; then, validate
the build directory; and when publishing, validate the repository
as well.
Using flatpak-builder-lint in the org.flatpak.Builder Flatpak in a
docker container seems to not work.
So the linter repo is cloned and Poetry is used to run it inside an
custom action.
"--exceptions" is required to allow the manifest to pass since
OBS Studio has one for "--talk-name=org.freedesktop.Flatpak".
Co-authored-by: Georges Basile Stavracas Neto <georges.stavracas@gmail.com>
Later conditional uses fromJSON expression which requires valid
references. If this step is skipped, the used reference will be invalid
(as the step has never run) and the entire expression will fail.
