OBS Studio - Free from stubborn peops
https://obsproject.com
2d7cda18e9
os_sleepto_ns() can occasionally return false on times that the processor may not have reached yet. The reason is because the count_target, which converts time_target into a QPC counter, is subject to a rounding error. Using numbers I generated from an actual clock cycle on my own CPU, I can show an example of this occurring: if the clock frequency value is 10000000.0, and you call os_sleepto_ns(42164590320600), it will convert that number first to a double floating point of its QPC value: 421645903205.99994. Then, because it converts that to a LONGLONG integer, it of course strips off the decimal point. If you convert 421645903205 *back* to a time value, the new value will be 42164590320500, which is lower than the original value by approximately 100 nanoseconds. While this may seem insignificant, it was apparently enough to cause the os_sleepto_ns() call in video_sleep() to sometimes return false despite the current time being lower than the target time, which would cause it to incorrectly calculate how many frames were duplicated by subtracting the frame time from the current system time, divide that by the current frame interval, set the vframe_info.count value to 0, and thus cause an infinite loop in the encode_gpu() function because queue_frame now starts returning negative numbers in perpetuity. This change fixes some rare reports of users having their video lock up and disconnect, forcing the user to have to forcibly shut down the program. Thanks to Twitch user SNLabat for having the patience to kindly provide us with a dump file from the freeze, and to Matt for coordinating with that user to obtain it from them. |
||
|---|---|---|
| .github | ||
| additional_install_files | ||
| CI | ||
| cmake | ||
| deps | ||
| docs/sphinx | ||
| libobs | ||
| libobs-d3d11 | ||
| libobs-opengl | ||
| libobs-winrt | ||
| plugins | ||
| test | ||
| UI | ||
| .cirrus.yml | ||
| .clang-format | ||
| .editorconfig | ||
| .git-blame-ignore-revs | ||
| .gitattributes | ||
| .gitignore | ||
| .gitmodules | ||
| .mailmap | ||
| AUTHORS | ||
| CMakeLists.txt | ||
| COC.rst | ||
| COMMITMENT | ||
| CONTRIBUTING.rst | ||
| COPYING | ||
| formatcode.sh | ||
| INSTALL | ||
| README.rst | ||
OBS Studio <https://obsproject.com> =================================== .. image:: https://github.com/obsproject/obs-studio/actions/workflows/main.yml/badge.svg?branch=master&event=push :alt: OBS Studio Build Status - GitHub Actions :target: https://github.com/obsproject/obs-studio/actions/workflows/main.yml?query=event%3Apush+branch%3Amaster .. image:: https://d322cqt584bo4o.cloudfront.net/obs-studio/localized.svg :alt: OBS Studio Translation Project Progress :target: https://crowdin.com/project/obs-studio .. image:: https://img.shields.io/discord/348973006581923840.svg?label=&logo=discord&logoColor=ffffff&color=7389D8&labelColor=6A7EC2 :alt: OBS Studio Discord Server :target: https://obsproject.com/discord What is OBS Studio? ------------------- OBS Studio is software designed for capturing, compositing, encoding, recording, and streaming video content, efficiently. It's distributed under the GNU General Public License v2 (or any later version) - see the accompanying COPYING file for more details. Quick Links ----------- - Website: https://obsproject.com - Help/Documentation/Guides: https://github.com/obsproject/obs-studio/wiki - Forums: https://obsproject.com/forum/ - Build Instructions: https://github.com/obsproject/obs-studio/wiki/Install-Instructions - Developer/API Documentation: https://obsproject.com/docs - Donating/backing/sponsoring: https://obsproject.com/contribute - Bug Tracker: https://github.com/obsproject/obs-studio/issues Contributing ------------ - If you would like to help fund or sponsor the project, you can do so via `Patreon <https://www.patreon.com/obsproject>`_, `OpenCollective <https://opencollective.com/obsproject>`_, or `PayPal <https://www.paypal.me/obsproject>`_. See our `contribute page <https://obsproject.com/contribute>`_ for more information. - If you wish to contribute code to the project, please make sure to read the coding and commit guidelines: https://github.com/obsproject/obs-studio/blob/master/CONTRIBUTING.rst - Developer/API documentation can be found here: https://obsproject.com/docs - If you wish to contribute translations, do not submit pull requests. Instead, please use Crowdin. For more information read this thread: https://obsproject.com/forum/threads/how-to-contribute-translations-for-obs.16327/ - Other ways to contribute are by helping people out with support on our forums or in our community chat. Please limit support to topics you fully understand -- bad advice is worse than no advice. When it comes to something that you don't fully know or understand, please defer to the official help or official channels.