4aiman/obs-studio
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
obs-studio/obs
History
jp9000 4093ce4d84 UI: Fix bug when canceling first source properties 
When you launch the source properties for the first time, the settings
for the source are empty and default values are used.  With the new
OK/Cancel buttons that were recently merged, it first saves the old
settings, then if the user cancels applies those old settings.

However, because the first settings are always empty, obs_source_update
will try to apply the old settings (which are empty) to the modified
settings, but it can't reset to those settings because it's technically
not applying any settings at all.

In other words, when you create the source and modified the properties
for your first time, pressing cancel would not reset anything at all.

This fixes that issue by clearing the current settings with
obs_data_clear before updating the source with the old settings, which
ensures that any settings that were empty are reset to an empty status.
2015-01-24 22:10:37 -08:00
..
data UI: Add Okay/Cancel Buttons to Properties Dialog 2015-01-15 21:49:03 -08:00
dist Add .desktop file for obs on linux 2014-08-05 21:15:31 +02:00
forms UI: Fix minor stylesheet issues 2015-01-14 02:15:30 -05:00
adv-audio-control.cpp obs: Fix signal in advanced volume controls 2015-01-02 20:11:40 +01:00
adv-audio-control.hpp UI: Add advanced audio properties dialog 2014-12-28 01:51:56 -08:00
CMakeLists.txt Add SOVERSION to libobs-opengl 2015-01-13 17:51:38 -08:00
crash-report.cpp UI: Add crash report dialog 2015-01-03 02:37:21 -08:00
crash-report.hpp UI: Add crash report dialog 2015-01-03 02:37:21 -08:00
display-helpers.hpp Ensure sizes passed to OBS are actual pixel sizes 2014-04-16 22:39:05 +02:00
obs-app.cpp (API Change) Make os_get_config_path safer to use 2015-01-15 23:44:38 -08:00
obs-app.hpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
platform-osx.mm Move config values from the commandline to obsconfig.h 2014-07-26 14:07:14 +02:00
platform-windows.cpp Move config values from the commandline to obsconfig.h 2014-07-26 14:07:14 +02:00
platform-x11.cpp UI: Fix bug with xinerama on linux 2014-12-22 01:12:58 +01:00
platform.hpp Add platform specific locale priority enumeration 2014-07-13 19:10:39 +02:00
properties-view.cpp UI: Removed an unnecesary setSizeConstraint call 2015-01-05 15:41:25 +02:00
properties-view.hpp UI: Use VScrollArea for properties view 2015-01-03 03:03:04 -08:00
qt-display.hpp Mark method as override 2014-01-25 07:23:57 +01:00
qt-wrappers.cpp Adjust OBSErrorBox severity 2014-07-13 15:23:26 +02:00
qt-wrappers.hpp Use only one widget for preview 2014-03-07 10:19:03 -07:00
source-list-widget.cpp UI: Add SourceListWidget - QListWidget subclass 2015-01-05 03:38:18 -08:00
source-list-widget.hpp UI: Add SourceListWidget - QListWidget subclass 2015-01-05 03:38:18 -08:00
sparkle-updater.mm sparkle-updater: Enable delta update failure fallback 2014-11-01 03:06:26 +01:00
vertical-scroll-area.cpp UI: Fix property scroll area widget not resizing 2015-01-03 07:31:51 -08:00
vertical-scroll-area.hpp UI: Always hide VScrollArea horizontal scroll bar 2015-01-03 07:32:04 -08:00
volume-control.cpp obs: Allow styling of volume meters 2015-01-14 02:01:20 -05:00
volume-control.hpp obs: Allow styling of volume meters 2015-01-14 02:01:20 -05:00
window-basic-adv-audio.cpp UI: Add advanced audio properties dialog 2014-12-28 01:51:56 -08:00
window-basic-adv-audio.hpp UI: Add advanced audio properties dialog 2014-12-28 01:51:56 -08:00
window-basic-interaction.cpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
window-basic-interaction.hpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
window-basic-main.cpp UI: Fix missing widget parent from constructor 2015-01-16 11:21:11 +02:00
window-basic-main.hpp UI: Save at regular intervals 2015-01-05 02:45:40 -08:00
window-basic-preview.cpp Do not draw selected item outline if selected item is invisible 2014-10-14 02:42:30 +02:00
window-basic-preview.hpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
window-basic-properties.cpp UI: Fix bug when canceling first source properties 2015-01-24 22:10:37 -08:00
window-basic-properties.hpp UI: Add Okay/Cancel Buttons to Properties Dialog 2015-01-15 21:49:03 -08:00
window-basic-settings.cpp UI: Add video scale filters to basic settings 2014-12-15 01:55:19 -08:00
window-basic-settings.hpp UI: Add video scale filters to basic settings 2014-12-15 01:55:19 -08:00
window-basic-source-select.cpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
window-basic-source-select.hpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
window-basic-status-bar.cpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
window-basic-status-bar.hpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
window-basic-transform.cpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
window-basic-transform.hpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
window-license-agreement.cpp Add license agreement dialog 2014-07-13 11:40:47 -07:00
window-license-agreement.hpp Add license agreement dialog 2014-07-13 11:40:47 -07:00
window-log-reply.cpp Add help menu with log file uploading 2014-05-18 17:44:10 -07:00
window-log-reply.hpp Add help menu with log file uploading 2014-05-18 17:44:10 -07:00
window-main.hpp (API Change) Remove pointers from all typedefs 2014-09-25 21:48:11 -07:00
window-namedialog.cpp Auto suggest scene and source names. 2014-05-12 15:01:51 -04:00
window-namedialog.hpp Auto suggest scene and source names. 2014-05-12 15:01:51 -04:00
window-remux.cpp Fix memory leak when opening and closing remux window without remuxing 2014-10-13 20:09:44 +02:00
window-remux.hpp Add UI for remuxing recordings via FFmpeg 2014-10-12 19:56:52 +02:00