ef0540c0d7
g_variant_lookup() obligatorily receives the type of the variant to
lookup. This function is used when retrieving the session handle
from the portal's response, and the variant type passed is "s" (a
string).
However, xdg-desktop-portal had a bug: the documentation explicitly
mentions that the session handle is an object path (of variant type
"o"), but it passed a string (of variant type "s"). This mismatch
was fixed in the xdg-desktop-portal release 1.10 [1], but that broke
the PipeWire capture code, which was passing specifically the "s"
value to the variant lookup.
Fix this by not checking the variant type at all. Object paths ("o")
are simply strings with a few extra checks, and we don't actually need
to perform these checks.
This change probably broke other apps, and that makes me extremely sad :(
[1] https://github.com/flatpak/xdg-desktop-portal/pull/609
|
||
|---|---|---|
| .. | ||
| data/locale | ||
| CMakeLists.txt | ||
| linux-capture.c | ||
| pipewire-capture.c | ||
| pipewire-capture.h | ||
| pipewire.c | ||
| pipewire.h | ||
| portal.c | ||
| portal.h | ||
| README | ||
| xcompcap-helper.cpp | ||
| xcompcap-helper.hpp | ||
| xcompcap-main.cpp | ||
| xcompcap-main.hpp | ||
| xcomposite-main.cpp | ||
| xcursor-xcb.c | ||
| xcursor-xcb.h | ||
| xcursor.c | ||
| xcursor.h | ||
| xhelpers.c | ||
| xhelpers.h | ||
| xshm-input.c | ||
Linux XShm capture plugin This plugin uses the MIT-SHM extension for the X-server to capture the desktop. Todo: - handle resolution changes of screens - handle adding/removing screens while recording - support different depths Contributing: If you are interested in helping out with the plugin, please drop by in the #obs-dev channel on quakenet. References: - http://www.x.org/releases/current/doc/xextproto/shm.html